Credential chains continue iterating after unexpected IMDS responses #23894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chlowell
force-pushed
the
chlowell/dac-aci
branch
from
2d49440 to
11393fb
Compare
chlowell
force-pushed
the
chlowell/dac-aci
branch
from
11393fb to
78614ae
Compare
chlowell
changed the title
chlowell
requested review from
jhendrixMSFT,
RickWinter and
a team
as code owners
chlowell
requested review from
joshfree,
pvaneck,
billwert,
ahsonkhan,
KarishmaGhiya,
scottaddie and
mpodwysocki
jhendrixMSFT
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23890 by fixing a regression in #23273, which had DefaultAzureCredential interpret a non-JSON response to its IMDS probe as indicating the server isn't IMDS or a supported imitator (I've filled the test gap that enabled the regression). This behavior is reasonable for IMDS, which always responds with JSON, but incorrect in general because ACI managed identity responds to the probe with a flat string.
The fix here is to accept any response to the probe request and return
credentialUnavailableErrorwhen an IMDS token response has an unexpected format. This change in error type applies only when ManagedIdentityCredential is part of a credential chain. When used by itself, ManagedIdentityCredential still returns AuthenticationFailedError for an unexpected IMDS response.